chore: Remove old detect-workflow action #1988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ian Lewis <[email protected]>
ianlewis
changed the title
Signed-off-by: Ian Lewis <[email protected]>
laurentsimon
approved these changes
Apr 13, 2023
| @@ -115,7 +115,7 @@ jobs: | |||
| - name: Detect the generator ref | |||
| id: detect | |||
| continue-on-error: true | |||
| uses: slsa-framework/slsa-github-generator/.github/actions/detect-workflow@main | |||
| uses: slsa-framework/slsa-github-generator/.github/actions/detect-workflow-js@main | |||
There was a problem hiding this comment.
we could as well rename the js action as detect-workflow. Maybe a follow-up PR.
There was a problem hiding this comment.
Yes. I was going to do it on this PR but it just made it unreadable so I'll do it in a follow up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1401
Removes the detect-workflow Docker container action in favor of the detect-workflow-js action. Also removes the base image verification pre-submit as it's not needed anymore.
/cc @asraa