Blank results visualization #311
Conversation
|
Taketo 3 typy mame:
Najma k tomu prvemu prazdnemu zoznamu, lebo tam (este) nic nie je, som hladal a nenasiel lepsiu ikonu. |
| @text1 = "Žiadne záznamy" | ||
| @text2 = "Zatiaľ nie sú vytvorené žiadne záznamy" | ||
| @icon = "hand-thumb-up" | ||
| when :not_found | ||
| @text1 = "Žiadne výsledky" | ||
| @text2 = "Skúste zmeniť filter alebo vyhľadávané slová" | ||
| @icon = "magnifying-glass" | ||
| when :all_done | ||
| @text1 = "Všetko je hotové" | ||
| @text2 = "Nemáte žiadnu novú správu" | ||
| @icon = "hand-thumb-up" |
There was a problem hiding this comment.
Toto presunme do translations file
| @@ -1,13 +1,14 @@ | |||
| <div class="flex flex-col justify-stretch items-stretch gap-4 sm:p-4"> | |||
| <div class="flex flex-col justify-stretch items-stretch sm:rounded-md bg-white sm:border sm:border-gray-200" data-controller="form all-checkboxes"> | |||
| <%= render MessageThreadsBulkActionsComponent.new(ids: [], filter: @filter, filter_subscription: @filter_subscription, signable: Current.user.signer?) %> | |||
| <%= form_with url: bulk_actions_message_threads_path, data: { "form-target": "form", "all-checkboxes-target": "form" } do %> | |||
| <%= form_with url: bulk_actions_message_threads_path, data: { 'form-target': "form", 'all-checkboxes-target': "form" } do %> | |||
There was a problem hiding this comment.
Davame, ale neprepisujeme stary kod. A vypli sme si enforcement tohto pravidla v nasom krasnom lintri, lebo to iritovalo head architekta ;-)
There was a problem hiding this comment.
Ja tu vidím diff kde sa zmenili
There was a problem hiding this comment.
Prauda, moja chyba. Tam je zjavne este dalsie pravidlo, ine ako pouzivanie jednoritych vs dvojitych. Vypinam aj toto
https://www.rubydoc.info/gems/rubocop/RuboCop/Cop/Style/QuotedSymbols
| <% else %> | ||
| <% component.with_blank_results_area do %> | ||
| <% if params[:referrer] == "menu" %> | ||
| <%= render Common::BlankResultsComponent.new(:all_done) %> |
There was a problem hiding this comment.
Toto neviem ci je uplne spravna logika, ak "idem z menu", tak mozem mat aj filter "Vybavene" a ked je prazdny tak nie je prave naopak NIC vybavene. Zaroven to posuvanie referera sa mi nepaci.
Spravme teda len tu verziu, ze ziadne spravy.
There was a problem hiding this comment.
No moja logika bola taka, ze ked idem z menu, tak je to nieco ako "TODO list", t.j. prazdny zoznam je dobry zoznam, a preto palec hore. A naopak, ked si robim custom query, tak asi nieco chcem najst, a ked nenajdem, tak je to v podstate chyba. Tomu som sa snazil aj ikony prisposobovat po inspiracii Figmou
| def initialize(reason = :not_found) | ||
| case reason | ||
| when :empty | ||
| @text1 = "Žiadne záznamy" |
There was a problem hiding this comment.
Toto je strasne genericke, blank stav by ti mal aj trochu poradit, ze naco to sluzi (napr. filtre) a ponuknut akciu (napr. vytvorit filter)
There was a problem hiding this comment.
Je to teda v prekladoch. Ak vies ako, kludne pomen
No description provided.