-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix build error under Linux 4.10 #3
base: master
Are you sure you want to change the base?
Conversation
An error was raised while compiling with Ubuntu 16.04 (kernel 4.10.0-32-generic): error: implicit declaration of function ‘is_compat_task‘
Had the same issue on Ubuntu 16.04 kernel 4.10.0-32-generic. This fix worked in allowing me to build! |
Thanks for the pull request! Looks like the travis job is fubar, but that's not related to this pull request. It will be a few days before I have time to test this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the pull request! For compatibility with older 4 series kernels would you mind removing the definition of is_compat_task
and adding #include <linux/compat.h>
to the file ./include/drv_types_linux.h
instead?
@@ -1171,5 +1171,10 @@ __inline static u8 *myid(struct eeprom_priv *peepriv) | |||
#include <pci_hal.h> | |||
#endif | |||
|
|||
static inline bool is_compat_task(void) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On kernel 4.4 I get a build error complaining about this function being redefined. Looks like kernel 4.10 has a header with a macro that defines this function. Would you mind changing the patch to remove this function, and add an #include <linux/compat.h>
instead?
In the meantime (one month after this PR) I'll try cloning ahresse:master. It also didn't work. |
https://github.com/ahresse/rtl8811au/wiki Testing on Ubuntu 17.04 x64 here. It seemed to install but unfortunately it didn't work as no WiFi networks appear, while they do in Windows on the same computer, and on my phone. I also tried to manually enter a WiFi connection, entering the SSID, WPA2/PSK passkey and MAC address, but it has never connected. |
I guess that I'll have to buy a Ubuntu compatible dongle... |
@jamesray1 Thanks for your feedback. You may want to try the code at https://github.com/diederikdehaas/rtl8812AU A year ago or so I bought a wifi dongle, and it came with a driver that didn't build on ubuntu xenial. I fixed the issues and uploaded it here in hopes that it would be useful to others like yourself. I no longer use a wifi dongle, so I'm probably not going to write more code for this repo. If you would be willing to fix issues you encounter (start with adding |
I bought another dongle that's compatible with Linux. I'll see how that goes. https://rover.ebay.com/rover/0/0/0?mpre=https%3A%2F%2Fwww.ebay.com.au%2Fulk%2Fitm%2F263200219618 |
This might be redundant but I'm just confirming that this worked for me.
The files were ./os_dep/linux/ioctl_linux.c and ./os_dep/linux/rtw_android.c This makes the build process finish smoothly with the current master version. |
An error was raised while compiling with Ubuntu 16.04 (kernel 4.10.0-32-generic):
error: implicit declaration of function ‘is_compat_task‘