fix(provider): prefer explicit provider IDs for current-model filtering - #224
Merged
Conversation
Exclude Antigravity-prefixed models from the shared Gemini matcher.\n\nReject normalization-only aliases when OpenCode reports an explicit provider ID.
Owner
|
@ugiya Thanks for fix! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
google, while unknown explicit IDs fail closedquota-providersThis PR is intentionally limited to issue #223. It does not include the unreleased OpenCode live-model accessor or the additional formatting/reactivity changes from the local integration.
Linked Issue
Fixes #223
OpenCode Validation
1.18.18providerIDseparately from an unprefixedmodelID, reproducing the identity mismatch described in the issue.Environment
26.5.1on Apple Silicon (arm64)1.18.18opencode-quotabase version4.8.124.16.0; pnpm11.0.0onlyCurrentModel: trueand multiple explicit providers{ "providerID": "openai", "modelID": "gpt-5.6-sol" }This PR is tested against the released host contract and does not depend on the proposed OpenCode live-model accessor.
Verification Performed
pnpm verifypassed twice: once immediately before commit and again in the repository's pre-push hook. The gate completed Biome checks, the pinned TypeScript check, history/privacy verification, typecheck, build, the full test suite, four-surface parity, and package-content verification.Results:
Focused regression coverage verifies:
openaiselects OpenAI for unprefixedgpt-5.6-solchatgpt,codex, andchutes-aiselect their catalog providergoogleidentity is disambiguated by Gemini versus Antigravity model metadataquota-providersretain exact provider/model matching+N issuesManual reproduction used the OpenCode
1.18.18TUI compact status with the environment and selection above.Quality Checklist
pnpm run typecheckpnpm run buildpnpm test