live-preview: account for transformation when highlighting items #9772
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #9760 Drag&drop over transformed item is still not working properly so this is disabled
hunger
approved these changes
Oct 18, 2025
| let supports_transformations = self | ||
| .window_adapter() | ||
| .map(|adapter| adapter.renderer().supports_transformations()) | ||
| .unwrap_or(true); |
There was a problem hiding this comment.
- Should this maybe default to
false? That seems safer. - Does it make sense to extract that into some helper function? You are repeating it below and it seems to be generically a useful bit of information that might be relevant in more places.
There was a problem hiding this comment.
- This just moves code around. Did that to move it outside of the loop. and i wanted to keep the two functions the same. Not sure true or false is any safer. If there is no window_adapter the result may be wrong.
- Yeah,
map_to_windowand `map_to_item_tree are duplicated code. I wanted to merge them actually. I wanted to actually merge them by calling one from the other, but i wasn't sure about the implications.
ogoffart
added a commit
that referenced
this pull request
Oct 21, 2025
ogoffart
added a commit
that referenced
this pull request
Oct 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9760
Drag&drop over transformed item is still not working properly so this is disabled