Skip to content

MarkdownText: don't inherit from SimpleText #9767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 21, 2025
Merged

MarkdownText: don't inherit from SimpleText #9767

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ccdacb2
MarkdownText: dont inherit from simpletext
expenses Oct 16, 2025
27b9b33
Apply suggestions
expenses Oct 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion internal/compiler/builtins.slint
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,16 @@ component ComplexText inherits SimpleText {

export { ComplexText as Text }

export component MarkdownText inherits SimpleText {
export component MarkdownText inherits Empty {
in property <length> width;
in property <length> height;
in property <string> text;
in property <length> font-size;
in property <int> font-weight;
in property <brush> color;
in property <TextHorizontalAlignment> horizontal-alignment;
in property <TextVerticalAlignment> vertical-alignment;

in property <string> font-family;
in property <bool> font-italic;
in property <TextOverflow> overflow;
Expand Down
2 changes: 1 addition & 1 deletion internal/compiler/passes/apply_default_properties_from_style.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ pub fn apply_default_properties_from_style(
}
});
}
"Text" => {
"Text" | "MarkdownText" => {
elem.set_binding_if_not_set("color".into(), || Expression::Cast {
from: Expression::PropertyReference(NamedReference::new(
&palette.root_element,
Expand Down
Loading