Add enabled property to animations to toggle them on/off
#9604
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds an `enabled` boolean property to the `animate` block, which defaults to `true`. When set to `false`, property changes apply immediately without animation, bypassing duration, easing, and iterations. - Added `enabled` field to PropertyAnimation struct - Updated compiler to handle enabled property with proper defaults - Added runtime check to skip animation when disabled - Included comprehensive tests for static and dynamic enabled values - Updated documentation and CHANGELOG
ogoffart
reviewed
Oct 5, 2025
There was a problem hiding this comment.
Thanks for the PR.
From an implementation point of view, i don't think this will work as expected.
The test only test what happens when the property value is set with a value.
However i don't think this will work in the following case:
- The animated property is a binding whose value is being changed because of another property
- The
enabledproperty is being changed after the animation is started.
One problem being that animation property are not reactive and this really limit the usefulness of this property. (see #348 )
So I think you will need more test involving bindings and disabling animation in-flight. (and probably fixing #348 might be a prerequisite)
| // Copyright © SixtyFPS GmbH <[email protected]> | ||
| // SPDX-License-Identifier: GPL-3.0-only OR LicenseRef-Slint-Royalty-free-2.0 OR LicenseRef-Slint-Software-3.0 | ||
|
|
||
| TestCase := Rectangle { |
There was a problem hiding this comment.
for new test, please use the new syntax with component TestCase {
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an
enabledboolean property to theanimateblock, which defaults totrue. When set tofalse, property changes apply immediately without animation, bypassing duration, easing, and iterations.enabledfield to PropertyAnimation struct