text item: improve partial rendering when unwrapped text changes #9437
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When Text elements in a vertical layout change their text, their height would be marked as dirty and thus the entire layout is invalidated. For text elements that don't wrap, the height solely depends on the font metrics. Note: The text element itself might still *render* above and below that. The dependency tracking here is covered by the bounding_rect() function and the individual text item's property dependency tracker in the partial renderer.
ogoffart
reviewed
Sep 16, 2025
There was a problem hiding this comment.
I'm not sure that's right.
Even with wrap: no-wrap (the default) a text can span multiple lines if there is actual new-line in it.
Maybe NoWrap is badly named. We could have a never-wrap variant that don't return on newlines.
although even then: an empty text shouldn't take space in the layout
|
Fair point! I'll extend this optimisation to include the line count for forced line-breaks. |
|
Err, I mean, change the optimisation to only apply when there are no forced line breaks. |
|
Ah crap, that means introducing a dependency on the text again :-( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Text elements in a vertical layout change their text, their height would be marked as dirty and thus the entire layout is invalidated. For text elements that don't wrap, the height solely depends on the font metrics.
Note: The text element itself might still render above and below that. The dependency tracking here is covered by the bounding_rect() function and the individual text item's property dependency tracker in the partial renderer.