Migrarte final api/node tests to Vitest #10114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tronical
reviewed
Nov 19, 2025
Member
Why not combine this in one? :) Or is the removal of Ava very complicated after all the tests have been ported? |
NigelBreslaw
force-pushed
the
nigel/node-api-vitest-4
branch
2 times, most recently
from
8bc5035 to
498e595
Compare
tronical
reviewed
Nov 19, 2025
NigelBreslaw
force-pushed
the
nigel/node-api-vitest-4
branch
from
85bdf64 to
d259645
Compare
tronical
approved these changes
Nov 19, 2025
This removes Ava from the monorepo as Vitest is now used for all javascript tests. This also adds a cleanup hook as running the tests locally could leave multiple instances of Node running in the background.
NigelBreslaw
force-pushed
the
nigel/node-api-vitest-4
branch
from
52a635f to
8b16084
Compare
burhankhanzada
pushed a commit
to burhankhanzada/slint
that referenced
this pull request
Nov 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.