Skip to content

Conversation

@AlbertBrand
Copy link
Contributor

@AlbertBrand AlbertBrand commented Dec 8, 2025

Previously the logic for resolving addons and themes was selecting the package that looked like slidev-{type}-{name} or @slidev/{type}-{name} and falling back to {name} if not found, so users can specify xyz to use for instance an addon called slidev-addon-xyz.

But in c53794b this behavior was changed to first check {name} over the others.

I have an extension called slidev-addon-tldraw that is dependent on tldraw. Since that change, the tldraw package is mistakenly loaded as addon, which is a no-op, but breaks the expected addon behavior.

This PR reverts to the old prioritization behavior as I think this is an unwanted regression.

@netlify
Copy link

netlify bot commented Dec 8, 2025

Deploy Preview for slidev ready!

Name Link
🔨 Latest commit 0697acb
🔍 Latest deploy log https://app.netlify.com/projects/slidev/deploys/6936d8940a58ca0008cc6b4e
😎 Deploy Preview https://deploy-preview-2398--slidev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Dec 8, 2025

Open in StackBlitz

@slidev/client

npm i https://pkg.pr.new/slidevjs/slidev/@slidev/client@2398

create-slidev

npm i https://pkg.pr.new/slidevjs/slidev/create-slidev@2398

create-slidev-theme

npm i https://pkg.pr.new/slidevjs/slidev/create-slidev-theme@2398

@slidev/parser

npm i https://pkg.pr.new/slidevjs/slidev/@slidev/parser@2398

@slidev/cli

npm i https://pkg.pr.new/slidevjs/slidev/@slidev/cli@2398

@slidev/types

npm i https://pkg.pr.new/slidevjs/slidev/@slidev/types@2398

commit: 0697acb

@AlbertBrand AlbertBrand changed the title fix: resolver should prioritize prefixed addons/themes fix: resolver should prioritize prefixed addons/themes again Dec 8, 2025
@antfu antfu merged commit cbcb500 into slidevjs:main Dec 9, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants