Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add django jalali settings #269

Merged
merged 6 commits into from
Jan 13, 2025

Conversation

mobinghoveoud
Copy link
Contributor

@mobinghoveoud mobinghoveoud commented Dec 20, 2024

close #266

Description of Changes

  • Added a settings class for accessing JALALI_SETTINGS in settings.py.
  • Added ADMIN_JS_STATIC_FILES and ADMIN_CSS_STATIC_FILES settings.
  • RefactoredAdminjDateWidget media handling.
  • Added documentation for settings and defaults.

Testing

  • Tested with Django 4.2
  • Tested with Django 5.1

@hramezani
Copy link
Collaborator

Thanks @mobinghoveoud for this PR. please:

@mobinghoveoud
Copy link
Contributor Author

Thanks for your review, @hramezani.
The changes have been made. Let me know if there's anything else.

@hramezani
Copy link
Collaborator

Thanks @mobinghoveoud for the update. LGTM 👍

I approved the PR and waiting for @slashmili to check.

We can merge it in some days and prepare a new release

@slashmili
Copy link
Owner

Sorry for the late reply, I was away.

Nice work @mobinghoveoud!

Thanks @hramezani for reviewing it. I'd assume we just need to bump the minor?

@slashmili slashmili merged commit dbc0376 into slashmili:main Jan 13, 2025
15 checks passed
@slashmili
Copy link
Owner

Released as 7.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants