Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change (place an x in the [ ] that applies)
Summary
Triagebot currently has a bug where some links aren't displaying as links
example:
![Screenshot 2025-02-05 at 12 57 54 PM](https://private-user-images.githubusercontent.com/35247622/410182928-849d2308-47de-4482-b4ce-7e394f46db7b.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk1NjM4NzEsIm5iZiI6MTczOTU2MzU3MSwicGF0aCI6Ii8zNTI0NzYyMi80MTAxODI5MjgtODQ5ZDIzMDgtNDdkZS00NDgyLWI0Y2UtN2UzOTRmNDZkYjdiLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTQlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE0VDIwMDYxMVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTlmNzcyMjVhYmM4YzUwMjBiM2JkYjdiZGJmYjVjM2NmNmFhM2UwMjQ1NDI3ZmQ1M2MzNzY5ZjMwODllYTY5ZmYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.GFfbgVn9FLUne2quTRHb3zNiuca4q5v28Wi4dmdId9c)
The issue here is that when we truncate the main slack message, its possible to truncate a link, channel, or user link (Eg
<channel,user,link>
). This causes a dangling<
to be left in the message which effects the next message below.To fix this bug, well be using a new regex to replace all dangling
<
after the message has been truncated this way it cant effect the next message.The channel, link, user will always be broken at the end because of the truncation but thats something we can try to solve another day
Testing
This function lacked testing so I decided to add some unit tests to test old behavior and new behavior im introducing
Requirements (place an x in each [ ] that applies)