Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check message attachment text as well #22

Merged
merged 2 commits into from
Aug 29, 2024

Conversation

frankeld
Copy link
Contributor

Check message attachment text for triage dots as well. While the attachments have multiple text fields, text is the most relevant for forwarded messages.

Copy link

Thanks for the contribution! Before we can merge this, we need @frankeld to sign the Salesforce Inc. Contributor License Agreement.

Copy link
Contributor

@yli919 yli919 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! One thing that I am not sure about is if all attachments will be of the type { [key: string]: string } 🤔 Do you have an example to confirm the payload type for attachment?

@frankeld
Copy link
Contributor Author

They won't be :)

            "attachments": [
                {
                    "service_name": "Leg end nary a laugh, Ink.",
                    "text": "This is likely a pun about the weather.",
                    "fallback": "We're withholding a pun from you",
                    "thumb_url": "https://badpuns.example.com/puns/123.png",
                    "thumb_width": 1920,
                    "thumb_height": 700,
                    "id": 1
                }
            ],

@yli919 yli919 merged commit 7910e98 into slack-samples:main Aug 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants