Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dialog and message dialog improvements #1836

Merged
merged 48 commits into from
Apr 8, 2025
Merged

Dialog and message dialog improvements #1836

merged 48 commits into from
Apr 8, 2025

Conversation

jpzwarte
Copy link
Member

@jpzwarte jpzwarte commented Mar 10, 2025

Fixes #1554 and #1859.

Copy link

changeset-bot bot commented Mar 10, 2025

🦋 Changeset detected

Latest commit: 083cc11

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 46 packages
Name Type
@sl-design-system/message-dialog Minor
@sl-design-system/bingel-dc Patch
@sl-design-system/bingel-int Patch
@sl-design-system/clickedu Patch
@sl-design-system/editorial-suite Patch
@sl-design-system/itslearning Patch
@sl-design-system/kampus Patch
@sl-design-system/magister Patch
@sl-design-system/max Patch
@sl-design-system/my-digital-book Patch
@sl-design-system/neon Patch
@sl-design-system/sanoma-learning Patch
@sl-design-system/teas Patch
@sl-design-system/shared Minor
@sl-design-system/dialog Major
@sl-design-system/accordion Patch
@sl-design-system/announcer Patch
@sl-design-system/avatar Patch
@sl-design-system/button Patch
@sl-design-system/checkbox Patch
@sl-design-system/data-source Patch
@sl-design-system/editor Patch
@sl-design-system/emoji Patch
@sl-design-system/form Patch
@sl-design-system/format-date Patch
@sl-design-system/format-number Patch
@sl-design-system/grid Patch
@sl-design-system/inline-message Patch
@sl-design-system/menu Patch
@sl-design-system/number-field Patch
@sl-design-system/paginator Patch
@sl-design-system/panel Patch
@sl-design-system/popover Patch
@sl-design-system/radio-group Patch
@sl-design-system/search-field Patch
@sl-design-system/select Patch
@sl-design-system/switch Patch
@sl-design-system/tabs Patch
@sl-design-system/tag Patch
@sl-design-system/text-area Patch
@sl-design-system/text-field Patch
@sl-design-system/toggle-button Patch
@sl-design-system/toggle-group Patch
@sl-design-system/tooltip Patch
@sl-design-system/tree Patch
@sl-design-system/tool-bar Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Mar 10, 2025

🕸 Website preview

You can view a preview here (commit 083cc118d0a8112f25e47ab9be08953b6fc6ff3c).

Copy link
Contributor

github-actions bot commented Mar 10, 2025

🕸 Storybook preview

You can view a preview here (commit 083cc118d0a8112f25e47ab9be08953b6fc6ff3c).

@DanielleRameau DanielleRameau linked an issue Mar 21, 2025 that may be closed by this pull request
3 tasks
@jpzwarte jpzwarte marked this pull request as ready for review April 7, 2025 08:38
@jpzwarte jpzwarte requested review from anna-lach and Diaan as code owners April 7, 2025 08:38
@jpzwarte jpzwarte changed the title Dialog improvements Dialog and message dialog improvements Apr 7, 2025
@Diaan
Copy link
Collaborator

Diaan commented Apr 7, 2025

The dialog in the website is missing the button:
image

@Diaan
Copy link
Collaborator

Diaan commented Apr 7, 2025

The focus ring is cropped:
image

@Diaan
Copy link
Collaborator

Diaan commented Apr 7, 2025

In other examples where we have just a button here we use a primary variant
image

@jpzwarte jpzwarte merged commit ab33cc8 into main Apr 8, 2025
11 of 14 checks passed
@jpzwarte jpzwarte deleted the feature/dialog branch April 8, 2025 11:50
This was referenced Apr 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Contextual Tokens] Refactor Dialog in code User focus can escape Dialog when navigating with tab
4 participants