-
-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
workflow: add ping-mesh workflow #1640
base: master
Are you sure you want to change the base?
Conversation
please squash your commits |
3ce5113
to
15c8d08
Compare
506df31
to
eb31dd0
Compare
eb31dd0
to
54bf4af
Compare
54bf4af
to
afbb4cc
Compare
You need to rebase and change the parameter names according to the new yaml tags |
afbb4cc
to
9cde40d
Compare
}); | ||
}).then(function () { | ||
return result | ||
}).finally(function () { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the order should be catch and finally
Hi @dvandra & @masco-enovance I was looking on this today, trying to make this work. It look os ok, but not working so well. I was able to get Also ... if you have any future plans to enhance and you can share it will be good ... we would like to enhance this workflow with the help of some students if possible so we want to sync on plans forward. |
run tests |
@eranra I did a review, and packets are not injected correctly, that's why you having random behaviour |
@eranra We have a doc with somes workflows/use cases ideas. I can share and we can discuss about that tomorrow during the weekly |
9cde40d
to
f7aa075
Compare
May be now it is working. |
dd8ba4a
to
f74f52a
Compare
var pktform = {}; | ||
client.gremlin.query(src).then(function(nodes) { | ||
nodes.forEach(function(node) { | ||
sources.push(node.Metadata.TID); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can just avoid to add the node in sources when dst == node.Metadata.T
f74f52a
to
04e727a
Compare
Check connectivity from/to multiple points at once