Fix: Unreviewed Prereq badge granted access to further claims#45
Merged
Fix: Unreviewed Prereq badge granted access to further claims#45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #38
Users can claim the "Member" achievement (which requires review) and immediately use it as a prerequisite to claim other badges, even though the claim hasn't been reviewed/approved yet. The prerequisite check only verifies claim existence, not validity.
Root Cause
The getUserClaim() function in src/lib/data/achievementClaim.ts returns any claim without validating:
This function is used in prerequisite checks in:
src/routes/achievements/[id]/claim/+page.server.ts(lines 38-41, 87-90)src/routes/claims/[claimId]/+page.server.ts(lines 44-47)