[ENH] deduplicate dependency checkers and isolate soft dependency imports by using skbase
#13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR deduplicates dependency checkers by using
skbase
, which is currently an implied dependency, and which contains equivalent functionality.This improves maintainability of the dependencies module through deduplication.
Importantly, it also helps with soft dependency isolation because the
skbase
dependency checker does not actually import all modules while checking - making future work on reducing impact of soft dependencies easier.In line with best practice,
packaging
andscikit-base
are added as dependencies topyproject.toml
, since there are now direct imports.No deprecation or change period is necessary, since both packages were already implied by core dependencies.
Requires pycaret#4124 because we are using
pyproject.toml
.