-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC improve documentation end-to-end pipeline #999
base: main
Are you sure you want to change the base?
DOC improve documentation end-to-end pipeline #999
Conversation
@jeromedockes This should be ready for a review. I wanted to add an example section in the user guide but I think that I'll fix first the backreference from sphinx-gallery first :). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @glemaitre, here are a few typo fixes and nitpicks
doc/end_to_end_pipeline.rst
Outdated
scikit-learn estimator, returns a pipeline that combines this estimator with the | ||
appropriate preprocessing steps. Those steps corresponds to a :class:`TableVectorizer` | ||
that is in charge of dealing with heterogeneous data and depending on the capabilities | ||
of the final estimator, a missing value imputer. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and/or a standard scaler?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, it was added since I started this PR :)
Co-authored-by: Vincent M <[email protected]>
Co-authored-by: Vincent M <[email protected]>
Co-authored-by: Vincent M <[email protected]>
Co-authored-by: Vincent M <[email protected]>
Just notice it's the reference #999 👀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :)
This is reworking the first section to bring more into light the
tabular_learner
before theTableVectorizer
.