Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC improve documentation end-to-end pipeline #999

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

glemaitre
Copy link
Member

This is reworking the first section to bring more into light the tabular_learner before the TableVectorizer.

@glemaitre glemaitre marked this pull request as draft July 12, 2024 16:49
@glemaitre glemaitre marked this pull request as ready for review September 2, 2024 12:42
@glemaitre
Copy link
Member Author

@jeromedockes This should be ready for a review. I wanted to add an example section in the user guide but I think that I'll fix first the backreference from sphinx-gallery first :).

Copy link
Member

@Vincent-Maladiere Vincent-Maladiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @glemaitre, here are a few typo fixes and nitpicks

doc/end_to_end_pipeline.rst Outdated Show resolved Hide resolved
scikit-learn estimator, returns a pipeline that combines this estimator with the
appropriate preprocessing steps. Those steps corresponds to a :class:`TableVectorizer`
that is in charge of dealing with heterogeneous data and depending on the capabilities
of the final estimator, a missing value imputer.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and/or a standard scaler?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, it was added since I started this PR :)

doc/end_to_end_pipeline.rst Outdated Show resolved Hide resolved
doc/end_to_end_pipeline.rst Outdated Show resolved Hide resolved
doc/end_to_end_pipeline.rst Outdated Show resolved Hide resolved
doc/end_to_end_pipeline.rst Outdated Show resolved Hide resolved
skrub/_table_vectorizer.py Outdated Show resolved Hide resolved
@Vincent-Maladiere
Copy link
Member

Just notice it's the reference #999 👀

Copy link
Member

@Vincent-Maladiere Vincent-Maladiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants