Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

281 notes #293

Merged
merged 2 commits into from
Apr 18, 2024
Merged

281 notes #293

merged 2 commits into from
Apr 18, 2024

Conversation

sroertgen
Copy link
Contributor

@sroertgen sroertgen commented Mar 27, 2024

Adds the following documentation properties:

  • skos:changeNote
  • skos:editorialNote
  • skos:historyNote

All note attributes properties (including skos:note and skos:scopeNote) now allow multiple entries.

Tests were added for all note attributes.

cc @carlschuurbiers

@sroertgen sroertgen self-assigned this Mar 27, 2024
@sroertgen sroertgen linked an issue Mar 27, 2024 that may be closed by this pull request
@sroertgen sroertgen requested a review from acka47 March 27, 2024 08:20
@sroertgen
Copy link
Contributor Author

Can't assign @carlschuurbiers as reviewer. But feel free to test this out as well

@sroertgen
Copy link
Contributor Author

@acka47 this PR was merged in dev. You can use the test environment for testing this PR.

@sroertgen sroertgen mentioned this pull request Mar 28, 2024
@sroertgen sroertgen assigned acka47 and unassigned acka47 Mar 28, 2024
acka47 added a commit to acka47/testing-skohub-vocabs that referenced this pull request Apr 17, 2024
@acka47
Copy link
Member

acka47 commented Apr 17, 2024

@acka47 this PR was merged in dev. You can use the test environment for testing this PR.

Is the test system somehow broken? I get this error: https://test.skohub.io/build/?id=b669982f-4d49-4f60-a776-bb0e59ccb386

The webhook was delivered from this repo fte rchanges in the master branch: https://github.com/acka47/testing-skohub-vocabs

@acka47
Copy link
Member

acka47 commented Apr 18, 2024

Test system seems to work but I get an error I do not understand quickly, see https://test.skohub.io/build?id=d673121d-d4d5-432c-a3df-15bc9a66095f

Copy link
Member

@acka47 acka47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 Works as expected

@sroertgen sroertgen merged commit cb9c670 into main Apr 18, 2024
3 checks passed
@sroertgen sroertgen deleted the 281-notes branch April 18, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

multiple entries for skos:notes causes "No note in language xx"
2 participants