Add exponential propagator with XF #256
Open
+505
−58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
June 26, 2025 10:02
- Group related variables together based on their purpose. - Update comments for better clarity.
- Copy `exponential.c` to create `exponential_xf.c` as a starting point.
- Define and modify variables and functions to support xf calculations. - Implement memory allocation and cleanup logic for these variables.
- Modify `el_propagator_xf.pyx` to enable Cython integration with `exponential_xf.c`. - Update `setup.py` to include `exponential_xf.c`.
- Add conditional debugging output. - Extend xf_print function so it accepts input from both RK4 and the exponential propagator, unifying the parameter contract. - Fix the mismatch in interpolation step between rk4 and exponential in xf_print input
- Added comment for exponential propagator function. - Relocated variables declarations to appropriate scopes. - Removed `// TODO: Use memset` from code and created a Git issue tracking it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
exponential.cfor clarity and maintainability.Documentation will be added in a follow-up PR.