Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove atty #671

Merged
merged 1 commit into from
Dec 27, 2024
Merged

chore: remove atty #671

merged 1 commit into from
Dec 27, 2024

Conversation

gallois
Copy link
Contributor

@gallois gallois commented Dec 27, 2024

This was done previously in #587, but I suspect it was unwillingly reintroduced in #586. I found it while running trivy and it still complained about an atty issue, although the project's history showed that it has already been removed.

[15.237s][remove-atty][~/Development/skim]$ rg atty
CHANGELOG.md
201:- [838ba21](https://github.com/skim-rs/skim/commit/838ba21) - remove atty (PR [#587](https://github.com/skim-rs/skim/pull/587) by [@LoricAndre](https://github.com/LoricAndre))
439:  Fix `isatty` check on more OS.

Checklist

check the box if it is not applicable to your changes

  • I have updated the README with the necessary documentation
  • I have added unit tests
  • I have added end-to-end tests
  • I have linked all related issues or PRs

Description of the changes

This was done previously in skim-rs#587, but I suspect it was unwillingly
reintroduced in skim-rs#586. I found it while running trivy and it still
complained about an atty issue, although the project's history showed
that it has already been removed
@gallois gallois changed the title Remove atty chore: remove atty Dec 27, 2024
@LoricAndre LoricAndre merged commit b265179 into skim-rs:master Dec 27, 2024
9 of 10 checks passed
@skim-rs-bot skim-rs-bot bot mentioned this pull request Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants