Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump unicode-width from 0.1.10 to 0.2.0 #580

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 7, 2024

Bumps unicode-width from 0.1.10 to 0.2.0.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Nov 7, 2024
@dependabot dependabot bot force-pushed the dependabot/cargo/unicode-width-0.2.0 branch from c75fef0 to ddee11c Compare November 7, 2024 17:20
@LoricAndre
Copy link
Contributor

There is a mention in the README that might impact us :

Note: If you are using unicode-width for linebreaking, the change treating \n as width 1 may cause behavior changes. It is recommended that in such cases you feed already-line segmented text to unicode-width. In other words, please apply higher level control character based line breaking protocols before feeding text to unicode-width. Relying on any character producing a stable width in this crate is likely the sign of a bug.

I tried adding a line break in the prompt, header and selection lines (using --read0) without seeing any regressions, and the CI looks fine so I think we can merge this. @yazgoo do you have anything more you want to test ?

@dependabot dependabot bot force-pushed the dependabot/cargo/unicode-width-0.2.0 branch 2 times, most recently from 4e414b8 to a98f8ad Compare November 12, 2024 13:49
Bumps [unicode-width](https://github.com/unicode-rs/unicode-width) from 0.1.10 to 0.2.0.
- [Commits](https://github.com/unicode-rs/unicode-width/commits)

---
updated-dependencies:
- dependency-name: unicode-width
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/cargo/unicode-width-0.2.0 branch from a98f8ad to 6a8ba7c Compare November 12, 2024 14:12
@LoricAndre LoricAndre merged commit d95f6bc into master Nov 12, 2024
5 checks passed
@dependabot dependabot bot deleted the dependabot/cargo/unicode-width-0.2.0 branch November 12, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant