Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return items of multi-select in order of selection #468

Merged
merged 47 commits into from
Nov 18, 2024

Conversation

otto-dev
Copy link
Contributor

@otto-dev otto-dev commented Jul 22, 2022

Fixes #464. Also preserves the order of --pre-select-items when returning them unchanged. The solution is very simple and natural. I have relied on this behavior a lot during the last few days, and it works fine.

The introduced linked-hash-map dependency will continue to receive bug-fixes and updates to rust versions, but there are not plans to add further features to the library.

otto-dev and others added 30 commits July 22, 2022 12:53
`skim` is packaged in more then the listed repositories. By referring to repology everyone can easily check whether their package manager of choice has it. Also the list at repology auto updates and includes the information which versions are packaged.
Upgrading to clap 3 has changed some behavior in clap, as the
version option is automatically populated. This means the custom
code has never been executed.

Lets fix this by using the clap built in functionality to automatically
use the crate version in the builtin version option.

This fixes commit 7d922a0

Signed-off-by: Levente Polyak <[email protected]>
Bumps [log](https://github.com/rust-lang/log) from 0.4.17 to 0.4.22.
- [Release notes](https://github.com/rust-lang/log/releases)
- [Changelog](https://github.com/rust-lang/log/blob/master/CHANGELOG.md)
- [Commits](rust-lang/log@0.4.17...0.4.22)

---
updated-dependencies:
- dependency-name: log
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [vte](https://github.com/alacritty/vte) from 0.11.0 to 0.13.0.
- [Release notes](https://github.com/alacritty/vte/releases)
- [Changelog](https://github.com/alacritty/vte/blob/master/CHANGELOG.md)
- [Commits](alacritty/vte@v0.11.0...v0.13.0)

---
updated-dependencies:
- dependency-name: vte
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
dependabot bot and others added 12 commits November 8, 2024 12:24
Bumps [derive_builder](https://github.com/colin-kiegel/rust-derive-builder) from 0.11.2 to 0.20.2.
- [Release notes](https://github.com/colin-kiegel/rust-derive-builder/releases)
- [Commits](colin-kiegel/rust-derive-builder@v0.11.2...v0.20.2)

---
updated-dependencies:
- dependency-name: derive_builder
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [shlex](https://github.com/comex/rust-shlex) from 1.1.0 to 1.3.0.
- [Changelog](https://github.com/comex/rust-shlex/blob/master/CHANGELOG.md)
- [Commits](https://github.com/comex/rust-shlex/commits)

---
updated-dependencies:
- dependency-name: shlex
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@LoricAndre
Copy link
Contributor

I updated it and switched to the widely used and maintained IndexMap
The E2E are updated

@LoricAndre LoricAndre requested a review from yazgoo November 8, 2024 11:42
@LoricAndre LoricAndre added enhancement dependencies Pull requests that update a dependency file labels Nov 8, 2024
@LoricAndre LoricAndre added this to the v0.11.0 milestone Nov 15, 2024
Cargo.toml Outdated Show resolved Hide resolved
@yazgoo yazgoo self-requested a review November 17, 2024 22:24
Copy link
Collaborator

@yazgoo yazgoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see previous question

@LoricAndre LoricAndre requested a review from yazgoo November 18, 2024 16:19
Copy link
Collaborator

@yazgoo yazgoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks ok to me

@LoricAndre LoricAndre merged commit 064b7b7 into skim-rs:master Nov 18, 2024
5 checks passed
@otto-dev otto-dev deleted the preserve-multi-select-order branch November 28, 2024 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multi-select should output items in order in which they were selected