-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return items of multi-select in order of selection #468
Merged
LoricAndre
merged 47 commits into
skim-rs:master
from
otto-dev:preserve-multi-select-order
Nov 18, 2024
Merged
Return items of multi-select in order of selection #468
LoricAndre
merged 47 commits into
skim-rs:master
from
otto-dev:preserve-multi-select-order
Nov 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`skim` is packaged in more then the listed repositories. By referring to repology everyone can easily check whether their package manager of choice has it. Also the list at repology auto updates and includes the information which versions are packaged.
Upgrading to clap 3 has changed some behavior in clap, as the version option is automatically populated. This means the custom code has never been executed. Lets fix this by using the clap built in functionality to automatically use the crate version in the builtin version option. This fixes commit 7d922a0 Signed-off-by: Levente Polyak <[email protected]>
Co-authored-by: ymnejmi <[email protected]>
Bumps [log](https://github.com/rust-lang/log) from 0.4.17 to 0.4.22. - [Release notes](https://github.com/rust-lang/log/releases) - [Changelog](https://github.com/rust-lang/log/blob/master/CHANGELOG.md) - [Commits](rust-lang/log@0.4.17...0.4.22) --- updated-dependencies: - dependency-name: log dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [vte](https://github.com/alacritty/vte) from 0.11.0 to 0.13.0. - [Release notes](https://github.com/alacritty/vte/releases) - [Changelog](https://github.com/alacritty/vte/blob/master/CHANGELOG.md) - [Commits](alacritty/vte@v0.11.0...v0.13.0) --- updated-dependencies: - dependency-name: vte dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [derive_builder](https://github.com/colin-kiegel/rust-derive-builder) from 0.11.2 to 0.20.2. - [Release notes](https://github.com/colin-kiegel/rust-derive-builder/releases) - [Commits](colin-kiegel/rust-derive-builder@v0.11.2...v0.20.2) --- updated-dependencies: - dependency-name: derive_builder dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [shlex](https://github.com/comex/rust-shlex) from 1.1.0 to 1.3.0. - [Changelog](https://github.com/comex/rust-shlex/blob/master/CHANGELOG.md) - [Commits](https://github.com/comex/rust-shlex/commits) --- updated-dependencies: - dependency-name: shlex dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
I updated it and switched to the widely used and maintained IndexMap |
LoricAndre
added
enhancement
dependencies
Pull requests that update a dependency file
labels
Nov 8, 2024
yazgoo
reviewed
Nov 17, 2024
yazgoo
approved these changes
Nov 17, 2024
yazgoo
requested changes
Nov 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see previous question
yazgoo
approved these changes
Nov 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks ok to me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #464. Also preserves the order of
--pre-select-items
when returning them unchanged. The solution is very simple and natural. I have relied on this behavior a lot during the last few days, and it works fine.The introduced
linked-hash-map
dependency will continue to receive bug-fixes and updates to rust versions, but there are not plans to add further features to the library.