Automatically generate a model attribution file#134
Open
areebuzair wants to merge 1 commit intosketchfab:masterfrom
Open
Automatically generate a model attribution file#134areebuzair wants to merge 1 commit intosketchfab:masterfrom
areebuzair wants to merge 1 commit intosketchfab:masterfrom
Conversation
…e when downloading a model
areebuzair
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a class called "SF_Attributions" to init.py. When downloading a model, if the model information is available publicly i.e. the model is public, a text file will automatically be generated which will contain the credits to the author and license information. The change was made to the SketchfabDownloadModel.execute() function.
Here is a video demo.
Preview:
