Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Dynamic Move Function Implementation #205

Merged
merged 9 commits into from
Feb 9, 2025

Conversation

Jagadeeshftw
Copy link
Contributor

Description

This PR change ensures that any player—regardless of their chosen color—can initiate and participate in the game without being constrained by a hard-coded turn order.

Related Issue(s)

Closes #202

Checklist:

  • Verified this is not a duplicate of any existing pull request

  • Performed a self-review of the code

  • Rebased to the last commit of the target branch (or merged it into my branch)

  • Linked the issues which this PR resolves

  • Documented the changes in code (API docs will be generated automatically)

Copy link

co-lead bot commented Feb 7, 2025

Thanks for your PR @Jagadeeshftw. It will be reviewed shortly.

@0xibs
Copy link
Collaborator

0xibs commented Feb 8, 2025

            let game_id = self.get_current_game_id();

I noticed you are getting game_id from another function. The game_id is supposed to be passed into the move() function as a parameter. get_current_game_id() only gets the total number of games created so far.

@Jagadeeshftw Jagadeeshftw force-pushed the refactor-move-function branch from 94e5cdb to c224fcb Compare February 9, 2025 05:45
@Jagadeeshftw
Copy link
Contributor Author

Updated it @0xibs

@0xibs 0xibs merged commit 202c11e into sivicstudio:dev Feb 9, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make move() function dynamic
2 participants