Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:add tests for join function #204

Merged
merged 1 commit into from
Feb 8, 2025

Conversation

emarc99
Copy link
Contributor

@emarc99 emarc99 commented Feb 7, 2025

Description

Added extensive tests for join function.

Related Issue(s)

Checklist:

  • Read the contributing docs (if this is your first contribution)

  • Verified this is not a duplicate of any existing pull request

  • Performed a self-review of the code

  • Rebased to the last commit of the target branch (or merged it into my branch)

  • Linked the issues which this PR resolves

  • Documented the changes in code (API docs will be generated automatically)

image

Copy link

co-lead bot commented Feb 7, 2025

Thanks for your PR @emarc99. It will be reviewed shortly.

Copy link
Collaborator

@0xibs 0xibs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0xibs 0xibs merged commit 6c69e72 into sivicstudio:dev Feb 8, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add test for join function
2 participants