Drop numpy 1 requirement #162
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Dropped numpy-1.x.x requirement and added support for numpy-2.x
Types of changes
Minimal refactoring at the cython code, swapped only type definitions (eg. np.int / np.int_/np.float ) to numpy 2 counterparts.
I added also worflow dispatch on lint docs and test, in order to assure complete compatibility with your test suite.
I also thank @emaballarin for indicating me the precise modifications to perform.
[UPDATE]
The tests on github actions pass, but one more issue remains. Your tests are up to python version 3.12. Using python-3.13 the specified version of jax (v 0.4.30) is not avaliable. Releasing the dependence on this specific version of jax is problematic since if I use an updated version of jax tests on differentiable information imbalance fail. A more detailed discussion in a second pull request.