recording: only update metafile offset after successfully parsing the change #2008
+9
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
we're using |
|
thinking about this, the 2 cases to check for an unexpected |
… change when under load it's possible that a metafile gets updated by rtpengine while it's still being read by the recording daemon. this can result in a WARNING being logged and the loop breaking. That section ends up unprocessed and any changes in it don't get applied. This change only updates the offset after a successful section read. Therefore, if a section is incomplete and the loop breaks, the next inotify event will retry that incomplete section and it should succeed
tombriden
force-pushed
the
meta-change-fix
branch
from
09e983a to
541fb27
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when under load it's possible that a metafile gets updated by rtpengine while it's still being read by the recording daemon. this can result in a WARNING being logged and the loop breaking. That section ends up unprocessed and any changes in it don't get applied. This change only updates the offset after a successful section read. Therefore, if a section is incomplete and the loop breaks, the next inotify event will retry that incomplete section and it should succeed