feat: add IsLark field to FeishuConfig to switch between Feishu and Lark domains#1753
Merged
yinwm merged 2 commits intosipeed:mainfrom Mar 18, 2026
Merged
feat: add IsLark field to FeishuConfig to switch between Feishu and Lark domains#1753yinwm merged 2 commits intosipeed:mainfrom
yinwm merged 2 commits intosipeed:mainfrom
Conversation
Add IsLark field to FeishuConfig to switch between Feishu and Lark domains. Also fix domain inconsistency where WS client defaulted to LarkBaseUrl while HTTP client used FeishuBaseUrl. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add is_lark field to config example, feishu docs, i18n translations, and web frontend form. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
yinwm
approved these changes
Mar 18, 2026
Collaborator
yinwm
left a comment
There was a problem hiding this comment.
LGTM! The core functionality is correctly implemented:
- API client correctly switches base URL using
lark.WithOpenBaseUrl() - WebSocket client correctly sets domain via
larkws.WithDomain() - Frontend form, i18n, and docs are complete
Two minor informational findings (non-blocking):
- Log message shows "Feishu" regardless of
IsLarkconfig - cosmetic only .env.examplemissingIS_LARKexample - not affecting functionality
These can be addressed in a follow-up if desired.
Collaborator
|
thanks for the pr |
Contributor
|
@liuliqiang 飞书和Lark域名切换这个功能很实用,通过一个 我们正在组建 PicoClaw Dev Group,方便贡献者们在 Discord 上交流协作。如果感兴趣的话,发封邮件到 |
j0904
pushed a commit
to j0904/picoclaw
that referenced
this pull request
Mar 22, 2026
…ark domains (sipeed#1753) * feat(feishu): add Lark (international) support via IsLark config field Add IsLark field to FeishuConfig to switch between Feishu and Lark domains. Also fix domain inconsistency where WS client defaulted to LarkBaseUrl while HTTP client used FeishuBaseUrl. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * docs: update documentation and web UI for Lark support Add is_lark field to config example, feishu docs, i18n translations, and web frontend form. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
renato0307
pushed a commit
to renato0307/picoclaw
that referenced
this pull request
Mar 26, 2026
…ark domains (sipeed#1753) * feat(feishu): add Lark (international) support via IsLark config field Add IsLark field to FeishuConfig to switch between Feishu and Lark domains. Also fix domain inconsistency where WS client defaulted to LarkBaseUrl while HTTP client used FeishuBaseUrl. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * docs: update documentation and web UI for Lark support Add is_lark field to config example, feishu docs, i18n translations, and web frontend form. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add IsLark field to FeishuConfig to switch between Feishu and Lark domains. Also fix domain inconsistency where
WS client defaulted to LarkBaseUrl while HTTP client used FeishuBaseUrl.
📝 Description
Lark 是飞书的国际化版本,API 完全一致,唯一区别是域名:
https://open.feishu.cn(lark.FeishuBaseUrl)https://open.larksuite.com(lark.LarkBaseUrl)本 PR 在
FeishuConfig中新增is_lark字段(环境变量PICOCLAW_CHANNELS_FEISHU_IS_LARK),设为true时自动将 HTTP client 和 WS client 的域名切换为 Lark 国际版。
同时修复了原有代码中 WS client 默认使用
LarkBaseUrl而 HTTP client 使用FeishuBaseUrl的域名不一致问题,统一默认为
FeishuBaseUrl。🗣️ Type of Change
🤖 AI Code Generation
🔗 Related Issue
N/A
📚 Technical Context (Skip for Docs)
github.com/larksuite/oapi-sdk-go) 已内置lark.LarkBaseUrl和lark.FeishuBaseUrl常量以及
lark.WithOpenBaseUrl/larkws.WithDomain选项,只需根据配置选择即可,无需额外依赖。🧪 Test Environment
📸 Evidence (Optional)
Click to view Logs/Screenshots
N/A(环境 Go 版本不匹配,未能本地运行完整构建,代码变更已通过人工审查确认正确性)
☑️ Checklist