Skip to content

docs: "exec" tool disabling#1703

Merged
yinwm merged 1 commit intosipeed:mainfrom
MaksimSkorobogatov:docs/issue-1621-exec-tool-disabling
Mar 19, 2026
Merged

docs: "exec" tool disabling#1703
yinwm merged 1 commit intosipeed:mainfrom
MaksimSkorobogatov:docs/issue-1621-exec-tool-disabling

Conversation

@MaksimSkorobogatov
Copy link
Contributor

📝 Description

🗣️ Type of Change

  • 🐞 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 📖 Documentation update
  • ⚡ Code refactoring (no functional changes, no api changes)

🤖 AI Code Generation

  • 🤖 Fully AI-generated (100% AI, 0% Human)
  • 🛠️ Mostly AI-generated (AI draft, Human verified/modified)
  • 👨‍💻 Mostly Human-written (Human lead, AI assisted or none)

🔗 Related Issue

Fixes #1621

☑️ Checklist

  • My code/docs follow the style of this project.
  • I have performed a self-review of my own changes.
  • I have updated the documentation accordingly.

@CLAassistant
Copy link

CLAassistant commented Mar 17, 2026

CLA assistant check
All committers have signed the CLA.

@sipeed-bot sipeed-bot bot added type: documentation Improvements or additions to documentation domain: tool labels Mar 17, 2026
Copy link
Collaborator

@yinwm yinwm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Thanks for documenting the exec tool disabling feature! The content is clear and helpful. However, I found some issues that need to be fixed before merging.


❌ Critical Issue: Missing Closing Backticks

In README.pt-br.md (line 705) and README.vi.md (line 677), the Fork bomb line is missing a closing backtick:

- * Fork bomb `:(){ :|:& };:
+ * Fork bomb `:(){ :|:& };:`

This will break the markdown rendering and cause the subsequent content to be rendered as inline code.

Files affected:

  • README.pt-br.md:705
  • README.vi.md:677

💡 Minor Suggestion

In README.md:857, the backticks around exec were removed (the exec tool instead of the \exec` tool`). This seems inconsistent with other references to the tool name in the same document. Consider keeping the backticks for consistency, or if this was intentional, maybe apply the same change across all language versions.


Summary

Please fix the missing backticks in the Portuguese and Vietnamese READMEs, then this PR should be good to merge! 🚀

@MaksimSkorobogatov
Copy link
Contributor Author

MaksimSkorobogatov commented Mar 17, 2026

@yinwm Thank you for your review!
I fixed the critical issue and applied you minor suggestion by adding the backticks (in body, ignoring titles for consistency with othre titles) in commit cf9304e

@MaksimSkorobogatov MaksimSkorobogatov force-pushed the docs/issue-1621-exec-tool-disabling branch from 36e71b2 to cf9304e Compare March 17, 2026 18:35
@yinwm
Copy link
Collaborator

yinwm commented Mar 18, 2026

plz fix conflicts, @MaksimSkorobogatov thanks

@yinwm
Copy link
Collaborator

yinwm commented Mar 18, 2026

@MaksimSkorobogatov plz sign CLA

@MaksimSkorobogatov MaksimSkorobogatov force-pushed the docs/issue-1621-exec-tool-disabling branch from 836c674 to 3f6aa4d Compare March 18, 2026 17:35
@MaksimSkorobogatov
Copy link
Contributor Author

@yinwm, i resolved conflicts, added documentation to more languages and merged last changes from main.

cla sining doesn't work :(

i tried it yesterday and today, it shows me
Снимок экрана 2026-03-18 в 8 43 29 PM but nothing changes

@yinwm
Copy link
Collaborator

yinwm commented Mar 19, 2026

@MaksimSkorobogatov you may check your email address, the one you commit should be in your github email list

@MaksimSkorobogatov MaksimSkorobogatov force-pushed the docs/issue-1621-exec-tool-disabling branch from 8b40871 to da6bfba Compare March 19, 2026 13:48
@MaksimSkorobogatov
Copy link
Contributor Author

@yinwm, it worked!
I had to disable the private email setting

Copy link
Collaborator

@yinwm yinwm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yinwm yinwm merged commit 16a7da7 into sipeed:main Mar 19, 2026
4 checks passed
@yinwm
Copy link
Collaborator

yinwm commented Mar 19, 2026

@MaksimSkorobogatov thanks for the pr

tong3jie pushed a commit to tong3jie/picoclaw that referenced this pull request Mar 20, 2026
@Orgmar
Copy link
Contributor

Orgmar commented Mar 20, 2026

@MaksimSkorobogatov Thanks for documenting the exec tool disabling! Having clear docs on how to control tool access is important for users managing security boundaries. Nice that it closes out #1621 too.

We have a PicoClaw Dev Group on Discord where contributors connect and collaborate. If you'd like to join, send an email to support@sipeed.com with subject [Join PicoClaw Dev Group] MaksimSkorobogatov and we'll send you the invite link!

j0904 pushed a commit to j0904/picoclaw that referenced this pull request Mar 22, 2026
@MaksimSkorobogatov MaksimSkorobogatov deleted the docs/issue-1621-exec-tool-disabling branch March 23, 2026 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

domain: tool type: documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature] make possible to disable the "exec" tool

4 participants