move off of cra to vite #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjquines
reviewed
Dec 8, 2024
psvenk
reviewed
Dec 8, 2024
psvenk
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working with CRA is a bit of a pain and there's been work to move off of it. I didn't update #57 since that involves the creation of a backend server too (which involves setting up XVM and all that) and this is more of an instant change, although rebasing that PR too would be good (maybe over IAP when ppl have more time?).
This PR moves off of CRA and moves to Vite. This also involves having to recreate some of the tooling integrated into CRA, such as an eslint config (a lot of the diffs in component files were issues flagged by tseslint that weren't being checked before). I didn't really have to change the workings of any components, which was nice. This issue also resolves all the security vulnerabilities found when running
npm install, and also closes #89.Doing this would probably make anything we want to do in the future, such as adding tests (which can be done with Vitest) or integrating a backend server (which can be done using a plugin), a bit easier.