Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is major overhaul of
scrapers/math_dept.py
. Even though I know it isn't actually being used in production, I still think it's good to make all the code as pretty and modular as possible for posterity.More specifically, the main code in
math_dept.py
(all the random stuff that used to be non-indented) is now divided into:run()
, the main entry point, which uses three other helper functions:get_rows()
for scrapingparse_subject(subject)
to parse the title specificallyparse_row(row)
to parse an individual rowtest_parse_when()
as a sanity check thatparse_when(when)
works properly