Fix timeslot parsing #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Properly account for timings that begin in the morning and end in the
evening by special-casing these rather than treating evening times as
morning times. Add assertions and give more detailed error messages.
This causes 15.089 ("W EVE (11-6 PM)") to be parsed correctly but also
results in early morning ROTC classes (such as NS.100) throwing errors
since we don't support times before 8:00 AM (these classes were
previously misidentified as evening classes).
dtemkin1
requested changes
Nov 30, 2024
Alwinfy
reviewed
Nov 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #79. Properly account for timings that begin in the morning and end in the evening by special-casing these rather than treating evening times as morning times. Add assertions and give more detailed error messages.
This causes 15.089 ("W EVE (11-6 PM)") to be parsed correctly (as 11:00 AM to 6:00 PM) but also results in early morning ROTC classes (such as NS.100) throwing errors since we don't support times before 8:00 AM (these classes were previously misidentified as evening classes).
It would also make sense to overhaul the timeslot system so that early morning classes can be supported, but I'll leave that to another pull request.