Add school year field to contest model and filter for contest selection #491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twalen
reviewed
Mar 26, 2025
oioioi/contests/models.py
Outdated
| @@ -108,6 +108,9 @@ class Contest(models.Model): | |||
| verbose_name=_("is archived"), | |||
| default=False | |||
| ) | |||
| school_year = models.CharField( | |||
| max_length=255, verbose_name=_("school year"), default="" | |||
There was a problem hiding this comment.
255 seems to be an overkill
twalen
reviewed
Mar 26, 2025
oioioi/contests/views.py
Outdated
| contests = sorted(contests, key=lambda x: x.creation_date, reverse=True) | ||
| context = { | ||
| 'contests' : contests, | ||
| 'filter' : filter_value, |
There was a problem hiding this comment.
the filtering should be handled by the server
MasloMaslane
reviewed
Apr 3, 2025
oioioi/contests/views.py
Outdated
| contests = sorted(contests, key=lambda x: x.creation_date, reverse=True) | ||
| filtered_contests = [] | ||
| for contest in contests: | ||
| if contest.school_year == filter_value or contest.name.find(filter_value) != -1 or contest.id.find(filter_value) != -1: |
There was a problem hiding this comment.
Couldn’t this be done in Django ORM? This would probably require adding a function visible_contests_queryset (i don’t think there is one yet)
MasloMaslane
requested changes
Apr 3, 2025
|
Also, since we are adding searching for contest, would it be possible to paginate contests in /contests/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #452. The filter field in the select contest page allows to search for contest by id, name or school year.