Searchbox bugfix #489
Searchbox bugfix #489
Conversation
| @@ -116,10 +116,10 @@ function init_search_selection(id) { | |||
| } else if (item.trigger !== 'problem') { | |||
| // At this point for anything other than a problem we | |||
| // want to create a search tag | |||
| const value = item.value || item.name; | |||
| const value = item.value; // IS THIS CHANGE GOOD? | |||
There was a problem hiding this comment.
Previously this value defaulted to item.name if item.value was not given.
As I am pretty sure that all places in the code where item.value was previously not given I changed it to be given, is the removal of this value defaulting to item.name a good change or is it still unnecessary?
oioioi/problems/views.py
Outdated
| result.extend(get_nonselected_origintag_hints(query)) | ||
| result.extend(get_origininfovalue_hints(query)) | ||
|
|
||
| if settings.PROBLEM_TAGS_VISIBLE or request.user.is_superuser: |
There was a problem hiding this comment.
This fix only ensures that hints related to tags are not given to non-superusers. It is still possible for any user to manually filter by the tags they want by changing the URL.
Should I make it so that it is impossible for non-superusers to filter by tags in such a way if they are hidden?
Should I make it so that superusers are also unable to filter by hidden tags, as the tags still don't show up next to tasks for them when PROBLEM_TAGS_VISIBLE = False?
oioioi/problems/tests/test_tags.py
Outdated
| @@ -159,7 +159,39 @@ class TestProblemSearchHintsTags(TestCase, AssertContainsOnlyMixin): | |||
| def get_query_url(self, parameters): | |||
| return self.url + '?' + urllib.parse.urlencode(parameters) | |||
|
|
|||
| @override_settings(LANGUAGE_CODE="en") | |||
| @override_settings(LANGUAGE_CODE="en", PROBLEM_TAGS_VISIBLE=False) | |||
| def test_search_no_hints_tags(self): | |||
There was a problem hiding this comment.
I added this test to make sure that with PROBLEM_TAGS_VISIBLE=False the hints do not show up. Should I duplicate each test that fails with PROBLEM_TAGS_VISIBLE=False like this?
oioioi/problems/tests/test_tags.py
Outdated
| @@ -209,7 +242,7 @@ def test_search_hints_origininfo(self): | |||
| self.assertEqual(response.status_code, 200) | |||
| self.assert_contains_only(response, ['origintag', 'round', 'year']) | |||
|
|
|||
| @override_settings(LANGUAGE_CODE="en") | |||
| @override_settings(LANGUAGE_CODE="en") # PROBLEM_TAGS_VISIBLE=True | |||
There was a problem hiding this comment.
Some tests still pass with PROBLEM_TAGS_VISIBLE=False, as they work on hint categories rather than hints themselves. Unclear on how to proceed with this.
…BLE = False (even for admin).
…danie', as 'Tags' are localised in Polish to 'Znaczniki' which caused false positives when checking if the task appeared in URL.
…aused name collisions.
Fixes #477. Fixes #485. Fixes #486.
Fix of three bugs related to the problemset searchbox I found while implementing #459 .