feat: Groupoid model identity and Pi types - #161
Merged
Merged
Conversation
Jlh18
marked this pull request as draft
October 30, 2025 13:26
Jlh18
changed the title
Jlh18
marked this pull request as ready for review
November 1, 2025 16:10
Jlh18
commented
Nov 1, 2025
|
|
||
| namespace hurewiczUTp | ||
|
|
||
| attribute [local irreducible] tpClovenIsofibration |
Collaborator
Author
There was a problem hiding this comment.
@Vtec234 is this an ok thing to do? After I actually defined what tpClovenIsofibration was (as opposed to stating it with a sorry) simp would crash with a "nested" error. I couldn't figure out what the issue was, but adding this irreducible attribute stopped the error.
Collaborator
There was a problem hiding this comment.
Yeah, I think it's fine. It would be good to also diagnose the underlying issue.
Vtec234
reviewed
Nov 2, 2025
|
|
||
| open CategoryTheory Functor.ClovenIsofibration | ||
|
|
||
| def tpClovenIsofibration : (GroupoidModel.U.{u}.tp).ClovenIsofibration := |
Collaborator
There was a problem hiding this comment.
Should this live in Groupoids/ rather than ForMathlib/?
Collaborator
Author
There was a problem hiding this comment.
i can move the whole file to Groupoids.
Vtec234
reviewed
Nov 2, 2025
| @@ -0,0 +1,659 @@ | |||
| import Mathlib.CategoryTheory.FiberedCategory.HomLift | |||
| import Mathlib.CategoryTheory.FiberedCategory.Fiber | |||
| import HoTTLean.Grothendieck.Groupoidal.IsPullback | |||
Collaborator
There was a problem hiding this comment.
We probably don't want to import non-ForMathlib modules in ForMathlib.
Vtec234
approved these changes
Nov 2, 2025
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.