Skip to content

Commit

Permalink
update setup.py and changelog.md
Browse files Browse the repository at this point in the history
  • Loading branch information
sgandhi1311 committed Apr 15, 2024
1 parent bcf7a97 commit 9885719
Show file tree
Hide file tree
Showing 3 changed files with 23 additions and 2 deletions.
18 changes: 18 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,23 @@
# Changelog

## 2.3.0

### Features
- **API Updates**
- Bumped to API version `202304` ([#64](https://github.com/singer-io/tap-linkedin-ads/pull/69))
- Updated API endpoints for the following streams: `campaign_groups`, `campaigns`, `creatives`

- **Pagination Enhancements**
- Implemented cursor-based pagination for the following streams: `accounts`, `campaign_groups`, `campaigns`, `creatives`

- **API Query Param Adjustments**
- Removed unsupported `pivot` and `pivotValue` from `fields` query parameters in Analytics API requests
- Incorporated these values within the tap to ensure consistency with the previous tap version

- **Video Ads Stream**
- Added new fields ([#71](https://github.com/singer-io/tap-linkedin-ads/pull/71))
- Requires scope - `r_organization_social` to sync the records.

## 2.2.0
* Bump to API version `202304`

Expand Down
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
from setuptools import setup, find_packages

setup(name='tap-linkedin-ads',
version='2.2.0',
version='2.3.0',
description='Singer.io tap for extracting data from the LinkedIn Marketing Ads API API 2.0',
author='[email protected]',
classifiers=['Programming Language :: Python :: 3 :: Only'],
Expand Down
5 changes: 4 additions & 1 deletion tap_linkedin_ads/streams.py
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,7 @@ def get_next_url(stream_name, next_url, data):
else:
next_url = None
else:
# handles index based paination
next_url = None
links = data.get('paging', {}).get('links', [])
for link in links:
Expand Down Expand Up @@ -341,6 +342,8 @@ def sync_endpoint(self,

urllist = []
if self.tap_stream_id in NEW_PATH_STREAMS:
# As per the latest linkedin version, few url formats are modified, it expects advertiser
# account_id in each url path
for account in account_list:
url = "{}/adAccounts/{}/{}?{}".format(BASE_URL, account, self.path, querystring)
urllist.append((account, url))
Expand Down Expand Up @@ -477,7 +480,7 @@ def sync_ad_analytics(self, client, catalog, last_datetime, date_window_size, pa
"""
# LinkedIn has a max of 20 fields per request. We cap the chunks at 18
# to make sure there's always room for us to append `dateRange`, and `pivotValues`
MAX_CHUNK_LENGTH = 17
MAX_CHUNK_LENGTH = 18

bookmark_field = next(iter(self.replication_keys))

Expand Down

0 comments on commit 9885719

Please sign in to comment.