Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update readme.md to clarify HTTPError #638

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update readme.md to clarify HTTPError #638

wants to merge 1 commit into from

Commits on Sep 24, 2024

  1. Update readme.md to clarify HTTPError 

    Clarifies that some errors (especially network errors) will not be an instance of HTTPError and not contain a response. Language copied from `hooks.beforeRetry`.

I believe it is important to reiterate this at the HTTPError level, as it is not immediately intuitive that all errors wouldn't be an instance of HTTPError.

Whether all errors *should* be an instance of HTTPError is up to debate (and I gather is actively under consideration in a number of issues/discussions), and is outside the scope of this PR.
    @gnowland
    gnowland authored Sep 24, 2024
    Configuration menu
    Copy the full SHA
    7c415ad View commit details
    Browse the repository at this point in the history