-
-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for passing a function to ky.extend() #611
Add support for passing a function to ky.extend() #611
Conversation
callback function receives parent's default options to allow extended instance to refer to modify parent options Closes sindresorhus#586
Thanks for working on this, looking good. Can you add a few more permutations to the tests? In particular, I want to make sure we cover:
|
@sholladay I've added some more test cases. I believe I've captured what you were targeting. |
Such a simple change, yet I think this will be a popular feature and cleanly solve a lot of use cases. Thanks again! |
I agree. Thank you for helping me add this change. I look forward to using it in my own projects! |
Will this be published soon? Doesn't look like this landed in |
Ah wow, thanks so much for getting to this to fast! Appreciate it 😄 |
callback function receives parent's default options to allow extended instance to refer to modify parent options
Closes #586