Clamp Retry-After time to retry.maxRetryAfter #603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We now use `maxRetryAfter` as a limit, rather than a threshold for canceling the retry. If `Retry-After` is greater than `maxRetryAfter`, then `Retry-After` will be capped.
This was referenced Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #390
This PR aims to make retry delays more intuitive.
Previously, we would respect the
Retry-Afterheader to determine the delay time for the retry, but ifRetry-Afterwas greater than theretry.maxRetryAfteroption, then the retry delay time would be set to0, effectively canceling it, given Ky's current logic.We now use
maxRetryAfteras a limit for the delay, rather than a threshold for canceling the retry. IfRetry-Afteris greater thanmaxRetryAfter, thenmaxRetryAfterwill be used as the delay time.