Allow explicitly unsetting hooks on .extend()
#599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The implementation here is pretty simple: just give hook merging some custom logic so it either merges OR resets to an empty array. Matches what was discussed in the related ticket. Documentation has been updated to describe this behavior as well. The dedicated test is just a modified copy of the existing `ky.extend()` one. Admittedly, I did modify a couple of other tests to cover the edge cases instead of building brand new tests. No reason other than noticing they were already close to what I needed and I'm being lazy. Closes #408
|
I left my thoughts on this approach here: #408 (comment) TL;DR: I don't like it. It continues down a path that is too convoluted and magical for my taste. That aside, the implementation in this PR looks good to me. |
…le-retry-after-statuses into kesills-better-extend-hooks Manual resolutions required: - Conflicts between my updated `extend()` tests in `test/main.ts` and the tests added with the new function form of `extend()`. Resolved by accepting their modified base test and just adding my changes, then putting my new `extend()` test below all their new cases. - Trivial resolution for import formatting in `source/core/Ky.ts`. - A change to `newHookValue` in `source/utils/merge.ts`, using `Object.hasOwn` per the linter's suggestion.
|
@sholladay This should be ready for re-review, following your latest comment in the related ticket. Conflict resolutions described in the merge commit. Thanks! |
sholladay
changed the title
.extend().extend()
|
LGTM. Thanks for the great discussion about how to incrementally improve the extend/merge logic. |
sholladay
pushed a commit
to crisshaker/ky
that referenced
this pull request
Jul 31, 2024
* feat: allow explicitly unsetting hooks on `.extend()` The implementation here is pretty simple: just give hook merging some custom logic so it either merges OR resets to an empty array. Matches what was discussed in the related ticket. Documentation has been updated to describe this behavior as well. The dedicated test is just a modified copy of the existing `ky.extend()` one. Admittedly, I did modify a couple of other tests to cover the edge cases instead of building brand new tests. No reason other than noticing they were already close to what I needed and I'm being lazy. Closes sindresorhus#408 * chore: remove unused import
This was referenced Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #408
The implementation here is pretty simple: just give hook merging some custom logic, so it either merges OR resets to an empty array. Matches what was discussed in the related ticket.
Documentation has been updated to describe this behavior as well.
The dedicated test is just a modified copy of the existing
ky.extend()one. Admittedly, I did modify a couple of other tests to cover the edge cases instead of building brand-new tests. No reason other than noticing they were already close to what I needed.. and I'm being lazy. 😅