Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add jsdoc type annotation for create function #2536

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add jsdoc type annotation for create function #2536

wants to merge 2 commits into from

Conversation

axetroy
Copy link
Contributor

@axetroy axetroy commented Jan 22, 2025

No description provided.

@sindresorhus
Copy link
Owner

If accepted, it would be great to update existing rules too.

@fisker
Copy link
Collaborator

fisker commented Jan 22, 2025

Actually our create is a little different than the ESLint one, maybe better define a new one?

  1. Listeners allow return/yield problem(s)
  2. context has addtional .on and .onExit methods

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sindresorhus sindresorhus sindresorhus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@axetroy @sindresorhus @fisker