-
-
Notifications
You must be signed in to change notification settings - Fork 27.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add VBA #3153
base: main
Are you sure you want to change the base?
Add VBA #3153
Conversation
Updated to fix some more of the awesome-lint issues which were overlooked. It should be noted that many of the awesome-lint issues which remain are due to the inclusion of symbology in the list. I personally feel this symbology is invaluable and a requirement due to the nature of VBA/VB6. List would significantly lose usability without it. |
Thanks for making an Awesome list! 🙌 It looks like you didn't read the guidelines closely enough. I noticed multiple things that are not followed. Try going through the list point for point to ensure you follow it. I spent a lot of time creating the guidelines so I wouldn't have to comment on common mistakes, and rather spend my time improving Awesome. |
@sindresorhus Can you be more precise, as currently I'm not sure if this response is merely automated? You can check the issue tracker to see I have gone through your requirements multiple times (over 4 passes now) so if it hasn't been picked up yet, it likely won't in another pass 😅 Please also see sindresorhus/awesome-lint#199 for reasons why the linter is failing. These failures were known about before the PR was submitted. |
@sancarn The linter doesn't like the links as they are invalid. The ![p_win] and ![a_all] syntax creates clickable images that link to a section of the document. The #- part is meant to serve as an anchor link, but since #- does not refer to any actual section in the document, clicking the images would not navigate to a meaningful place within the document. Can you link them to somewhere else in the document? Or use different emojis? |
Yeah this is our expected cause as well. Hence why we raised sindresorhus/awesome-lint#199
We did discuss this, and though we feel it would be doable, we also feel it would significantly decrease the usability of the document, (and would make the document much less awesome!) |
🏧 |
who is this? Where are these email?
Oğuzhan ÇART ***@***.***>於 2024年9月3日 週二,08:07寫道:
… This is an automated response to help you with this issue. Please let us
know if you need further assistance.
—
Reply to this email directly, view it on GitHub
<#3153 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ASM7JGM7JQEUQD5BNANI2MLZUT4SLAVCNFSM6AAAAABMTASYMKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMRVGM4TINRYGU>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Ok |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding icons after the items in the list would look better. |
@Axorax interesting, i disagree from the perspective that currently icons are aligned therefore easy to parse
vs
In the latte case you are having to search to the end of the sentence continually, and this may be on a new line etc. In the former case they are right at the front and all aligned together. So I personally feel this is better. |
awesome-vba
This PR is to add VBA to the list of programming languages.
VBA is extremely limited in its base form, and libraries are so critical to developing large software today. VBA doesn't have a package manager which means it's often difficult to find VBA libraries.
awesome-vba
solves this issue by collating all the best libraries in one place. It also includes some useful learning resources for people looking to learn the langauge.I have assessed all requirements and made sure that the awesome list complies with all relevant requirements. You can find my issue tracker here.
It is important to note that due to the nature of the VBA language, we cannot fully comply with the requirement below, which IMO only really makes sense for modern languages:
Requirements for your pull request
Add Name of List
. It should not contain the wordAwesome
.Add Swift
Add Software Architecture
Update readme.md
Add Awesome Swift
Add swift
add Swift
Adding Swift
Added Swift
- [iOS](…) - Mobile operating system for Apple phones and tablets.
- [Framer](…) - Prototyping interactive UI designs.
- [iOS](…) - Resources and tools for iOS development.
- [Framer](…)
- [Framer](…) - prototyping interactive UI designs
#readme
.- [Software Architecture](https://github.com/simskij/awesome-software-architecture#readme) - The discipline of designing and building software.
Requirements for your Awesome list
That means 30 days from either the first real commit or when it was open-sourced. Whatever is most recent.
awesome-lint
on your list and fix the reported issues. If there are false-positives or things that cannot/shouldn't be fixed, please report it.awesome-list-item
Bug with selection of link to validate awesome-lint#199main
, notmaster
.Mobile operating system for Apple phones and tablets.
Prototyping interactive UI designs.
Resources and tools for iOS development.
Awesome Framer packages and tools.
If you have not put in considerable effort into your list, your pull request will be immediately closed.
awesome-name-of-list
.awesome-swift
awesome-web-typography
awesome-Swift
AwesomeWebTypography
# Awesome Name of List
.# Awesome Swift
# Awesome Web Typography
# awesome-swift
# AwesomeSwift
awesome-list
&awesome
as GitHub topics. I encourage you to add more relevant topics.Awesome X
and a logo withAwesome X
. You can put the header image in a#
(Markdown header) or<h1>
.Contents
, notTable of Contents
.Contributing
orFootnotes
sections.https://github.com/<user>/<repo>/community/license/new?branch=main&template=cc0-1.0
(replace<user>
and<repo>
accordingly).license
orLICENSE
in the repo root with the license text.Licence
section to the readme. GitHub already shows the license name and link to the full text at the top of the repo.unicorn
.contributing.md
. The casing is up to you.Contributing
, positioned at the top or bottom of the main content.Footnotes
section at the bottom of the readme. The section should not be present in the Table of Contents.Example:
- [AVA](…) - JavaScript test runner.
Node.js
, notNodeJS
ornode.js
.You can still use a CI for linting, but the badge has no value in the readme.
Inspired by awesome-foo
orInspired by the Awesome project
kinda link at the top of the readme. The Awesome badge is enough.