DEVEXP-1276: (Conversation) OAS sync - Sprint 2#227
Open
asein-sinch wants to merge 2 commits intofeature/number-lookupfrom
Open
DEVEXP-1276: (Conversation) OAS sync - Sprint 2#227asein-sinch wants to merge 2 commits intofeature/number-lookupfrom
asein-sinch wants to merge 2 commits intofeature/number-lookupfrom
Conversation
asein-sinch
requested review from
JPPortier,
matsk-sinch and
rpredescu-sinch
as code owners
JPPortier
approved these changes
Mar 16, 2026
| console.log('* Messages_ListMessagesByChannelIdentity *'); | ||
| console.log('******************************************'); | ||
|
|
||
| const phoneNumber = getPhoneNumberFromConfig().substring(1); |
There was a problem hiding this comment.
We could add a comment to explain "why" .substring(1) or having a dedicated helper function with naming helping to understand
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref: https://gitlab.com/sinch/sinch-projects/enterprise-and-messaging/documentation/developer-experience/oas-documentation/-/merge_requests/568