sc-13562 #235
Open
sc-13562 #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # k8s/manifests/kube-prometheus/monitoring.jsonnet
The grafanaDashboards variable was declared but not used anywhere in the code. Removing it helps to clean up the code and prevent any potential confusion for future maintenance.
Eliminated a redundant addition of dhis2Server grafanaDashboards in monitoring.jsonnet to avoid duplicated configurations. This change ensures that the rtslExporterAlerts grafanaDashboards are included only once, improving configuration clarity and correctness.
Integrated rtslExporterAlerts.prometheusRules into the monitoring configuration for the sandbox environment. This ensures that RTSL exporter alerts are active when isEnvSandbox is true. Additionally, removed redundant rtslExporterAlerts rule declaration outside the sandbox check.
Updated the naming convention from 'rtsl_exporter' to 'rtsl-exporter' in all relevant fields. This change aligns the naming format with other components and ensures consistency across the manifests.
This change modifies the alert rule for the RTSL Exporter to trigger after 3 seconds of downtime instead of 5 minutes. This aims to provide quicker notifications for potential issues with the RTSL Exporter service.
Replaced 'up' check with 'absent_over_time' for better accuracy. Extended alert duration from 3 seconds to 1 minute. Improved alert descriptions for clarity.
# Conflicts: # k8s/manifests/kube-prometheus/monitoring.jsonnet
Consolidate Prometheus monitoring rules for the sandbox environment. Ensure `rtslExporterAlerts.prometheusRules` is properly included along with other rules when `isEnvSandbox` is true.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Story card: SC-13558