Annotate injections - #160
Merged
Merged
Conversation
… it, instead of reconstructing a sparse sum from the payload's type.
…d into the untyped injection, resolving a constructor to a named record instead of a positional triple.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two changes to how injections are handled, in preparation for typing a constructor at the name it was declared under.
Store the sum type on the node.
Typed.Expr.injcarries the sum it injects into, instead of the verifier reconstructingsum(empty, …, payloadTy, …, empty)from the payload's type. The verifier checks the annotation withinjComponents?— the sum must havearitycomponents and itstag-th must be the payload's type — so nothing downstream has to trust the elaborator.compileInj_correctreads the components off that check rather than rebuilding them.Carry the declaring type name from the frontend.
Untyped.Expr.injgains theTypeNameits constructor was declared under. The frontend resolves the constructor against its declaration anyway, so the name is already at hand; the elaboration environment's constructor table becomes aCtorInforecord (tag,arity,owner,payload) instead of a positional triple. Typing ignores the field for now — it is what lets a later commit type an injection at its name, with the declaration's parameters solved from the use site, so[]no longer needs a sum reconstructed around it.Build and full testsuite green.
🤖 Generated with Claude Code