Fill in dropped annotations and unaccounted attributes in the frontend - #157
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes the frontend gaps where an annotation or an attribute was silently dropped, and makes local recursion usable.
letpattern (let (x : T) = e) or on a match-arm payload is honored instead of discarded, so a wrong type is caught and a[@spec]written there is not lost.letthat takes arguments is rejected rather than dropped, since the annotation there is the return type written after the arguments (and OCaml rejects the syntax outright).letwith no arguments that is annotated both on its binder and after it is rejected, instead of the second annotation being silently dropped.[@@spec]nor[@@fn]may be written twice.:0:0.let recbinding a function literal is supported, which was the only way to give a local recursive function a specification and so the only way to write one at all.(e : t)is still dropped (Support type assignments (e : t) #155) and()is still rejected in a binder position (Accept () in a binder position #156).