Improve transition management #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* adds ToNameMatcher for identify destination name (TO CLIP NAME) in a transition event. While (TO FROM NAME) Name is pushed to the previous entry on the list. * Update regular expression for EFFECTS Matcher. As Working with Toon Boom Storyboard Pro EDL files, its output uses a different phrasing for EFFECTS comment. * Move Location for next_event assignment in EventMatcher.apply(). Reason: After a transition event, the event didn't have value for next_event so it was preventing iteration. Only Cut assigned the property. (Tested for my known cases)
mmartinez1972
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While (TO FROM NAME) Name is pushed to the previous entry on the list.
As Working with Toon Boom Storyboard Pro EDL files, its output uses a different phrasing for EFFECTS comment.
Reason:
After a transition event, the event didn't have value for next_event so it was preventing iteration. Only Cut assigned the property.
(Tested for my known cases)