Skip to content

Fix CRLF line endings correctly when preparing text for insertion #392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix CRLF line endings correctly when preparing text for insertion #392

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions Sources/Runestone/TextView/Core/TextInputView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1320,12 +1320,8 @@ extension TextInputView {

private func prepareTextForInsertion(_ text: String) -> String {
// Ensure all line endings match our preferred line endings.
var preparedText = text
let lineEndingsToReplace: [LineEnding] = [.crlf, .cr, .lf].filter { $0 != lineEndings }
for lineEnding in lineEndingsToReplace {
preparedText = preparedText.replacingOccurrences(of: lineEnding.symbol, with: lineEndings.symbol)
}
return preparedText
let lines = text.split(omittingEmptySubsequences: false, whereSeparator: \.isNewline)
return lines.joined(separator: lineEndings.symbol)
}
}

Expand Down
Loading