Fix mpls_label match view in ofl-strcurs-print.c#1
Open
simhond wants to merge 226 commits intosimhond:masterfrom
Open
Fix mpls_label match view in ofl-strcurs-print.c#1simhond wants to merge 226 commits intosimhond:masterfrom
simhond wants to merge 226 commits intosimhond:masterfrom
Conversation
A simple python utility which helps monitoring and debugging the flows set at the switch (using OF1.3). It displays the flows per table in a more convinient way. It uses the dpctl tool to send the flow stats req. To run the application simply supply the datapath used, for example: pyhon2.7 dpctl_parser.py unix:/var/run/dp0
…ation id in case of OFPCR_ROLE_NOCHANGE. Fix suggested by shh0613
Correction in installation instructions
misc fixes
… match overlap on all oxm matches causes segmentation fault due to unitialized hash map. Fix: When parsing IPv6, increase the lenght of the match.
…the packet contains a VLAN id.
Fix a buffer mismanagement bug that causes the udatapath to crash if the...
note more of required packages
… a default case, leading to a crash if the instruction type is unknown.
… the content of OF messages stored in a file. I use a combination of tcpdump and tcpflow to dump OF messages.
VLAN presence is not guaranteed by match prerequisites, so check for the field existence.
OpenFlow Specification 1.3.3 (https://www.opennetworking.org/images/stories/downloads/sdn-resources/onf-specifications/openflow/openflow-spec-v1.3.3.pdf), p. 65: "The value in the payload of the OXM TLV must be valid, in particular the OFPVID_PRESENT bit must be set in OXM_OF_VLAN_VID set-field actions."
OpenFlow Specification 1.3.3 (https://www.opennetworking.org/images/stories/downloads/sdn-resources/onf-specifications/openflow/openflow-spec-v1.3.3.pdf), p. 65: "The value in the payload of the OXM TLV must be valid, in particular the OFPVID_PRESENT bit must be set in OXM_OF_VLAN_VID set-field actions."
Fix a case switch that is not handling unknown instruction types with a ...
A couple of fixes.
This allows using both decimal and hexadecimal values for metadata and mask.
This commit fixes the warning: invalid suffix on literal; C++11 requires a space between literal and string macro [-Wliteral-suffix] when compile the switch using gcc 7.3 on Ubuntu 18.04.
Fix incorrect bitwise comparison when checking port configuration.
Fix gcc 7.3 warning for -Wliteral-suffix
Add to set_field in dpctl: UDP source / destination port
Parse masks in dpctl
This problem was pointed by @nikchez01 some time ago. This commit handles the specific error message when trying to remove a queue that was not configured.
dpctl queue-get-config is showing only 1 queue.
This commit fixes #278.
It fixes the connection with controllers that send the hello elements. It needs to be handled properly, though.
This commit fixes #104.
This commit complies with OpenFlow 1.3.5, keeping the same statistics from the modified meter entry.
…s. (#286) This commit fix the loop that populates the table features struct with valid goto ids which could be reachable from the current table when using goto instructions.
This commit fixes some errors when configuring and compiling the switch without gcc optmization flags (./configure CFLAGS='-g -O2' CXXFLAGS='-g -O2').
Because it was breaking compatibility with Mininet.
#290) When parsing these flow-mod strings (argc == 2), the memcpy is being used to copy the string. However, the memcpy was configured with a wrong number of bytes to copy, skipping the last null string char. This was leading to random error depending on the memory garbage content.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
16 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix mpls_label match view in ofl-strcurs-print.c
Should cast the value before getting the int32 out of it
case OFPXMT_OFB_MPLS_LABEL:
fprintf(stream, "mpls_label="0x%lx"",( (uint32_t)f->value) & 0x000fffff);
instead of
fprintf(stream, "mpls_label="%d"",((uint32_t) *f->value) & 0x000fffff);